[Lldb-commits] [PATCH] D132815: [LLDB] Do not dereference promise pointer in `coroutine_handle` pretty printer

[Adrian Prantl via Phabricator via lldb-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Seems fine if Pavel is happy with it.



================
Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:249
     def __init__(self, name=None, value=None, type=None, summary=None,
-                 children=None):
+                 children=None, dereference=None):
         """
----------------
That looks like a useful addition!


================
Comment at: lldb/source/Plugins/Language/CPlusPlus/Coroutines.cpp:21
   if (!valobj_sp)
-    return nullptr;
+    return LLDB_INVALID_ADDRESS;
 
----------------
Some day we should start returning `Optional<addr_t>` ...


================
Comment at: lldb/source/Plugins/Language/CPlusPlus/Coroutines.cpp:212
+
+  // Create the `resume` and `destroy` children
+  auto &exe_ctx = m_backend.GetExecutionContextRef();
----------------
`.`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132815/new/

https://reviews.llvm.org/D132815