[Lldb-commits] [PATCH] D133670: [LLDB][RISCV] Add RVM and RVA instruction support for EmulateInstructionRISCV

Tue Sep 20 21:00:20 PDT 2022

Emmmer added a comment.

In D133670#3804437 <https://reviews.llvm.org/D133670#3804437>, @aprantl wrote:

> Hey @Emmmer the unit test is throwing a UBSAN failure, could you please take a look?
>
> https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-sanitized/lastFailedBuild/testReport/lldb-unit/Instruction___EmulatorTests_3/26/
>
>   Stacktrace
>   Script(shard):
>   --
>   GTEST_OUTPUT=json:/Users/buildslave/jenkins/workspace/lldb-cmake-sanitized/lldb-build/tools/lldb/unittests/Instruction/./EmulatorTests-lldb-unit-48390-3-26.json GTEST_SHUFFLE=1 GTEST_TOTAL_SHARDS=26 GTEST_SHARD_INDEX=3 /Users/buildslave/jenkins/workspace/lldb-cmake-sanitized/lldb-build/tools/lldb/unittests/Instruction/./EmulatorTests
>   --
>   
>   Note: This is test shard 4 of 26.
>   Note: Randomizing tests' orders with a seed of 42603 .
>   [==========] Running 1 test from 1 test suite.
>   [----------] Global test environment set-up.
>   [----------] 1 test from RISCVEmulatorTester
>   [ RUN      ] RISCVEmulatorTester.TestAtomicSequence
>   /Users/buildslave/jenkins/workspace/lldb-cmake-sanitized/llvm-project/lldb/unittests/Instruction/RISCV/TestRISCVEmulator.cpp:254:3: runtime error: store to misaligned address 0x61b000001034 for type 'uint64_t' (aka 'unsigned long long'), which requires 8 byte alignment
>   0x61b000001034: note: pointer points here
>     af 27 04 10 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00
>                 ^ 
>   SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /Users/buildslave/jenkins/workspace/lldb-cmake-sanitized/llvm-project/lldb/unittests/Instruction/RISCV/TestRISCVEmulator.cpp:254:3 in 
>   
>   --
>   exit: -6
>   --
>   shard JSON output does not exist: /Users/buildslave/jenkins/workspace/lldb-cmake-sanitized/lldb-build/tools/lldb/unittests/Instruction/./EmulatorTests-lldb-unit-48390-3-26.json

Thanks for your feedback! it was fixed in rG07d0ef306b74fbcede432ad3480d2f299c051a98 <https://reviews.llvm.org/rG07d0ef306b74fbcede432ad3480d2f299c051a98>

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133670/new/

https://reviews.llvm.org/D133670