[Lldb-commits] [PATCH] D133910: [NFCI] Refactor FormatterContainerPair into TieredFormatterContainer.

Jorge Gorbe Moya via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Sep 20 18:31:21 PDT 2022


jgorbe updated this revision to Diff 461775.
jgorbe added a comment.

Address review feedback:

- Removed asserts on `GetXXXAtIndex` methods when the index is out of range. Return a default-initialized shared_ptr of the right type instead (which will result in an invalid value when returned back to the SB API).
- Removed unnecessary braces to follow the style guide.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133910/new/

https://reviews.llvm.org/D133910

Files:
  lldb/include/lldb/DataFormatters/FormattersContainer.h
  lldb/include/lldb/DataFormatters/TypeCategory.h
  lldb/source/API/SBTypeCategory.cpp
  lldb/source/DataFormatters/TypeCategory.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133910.461775.patch
Type: text/x-patch
Size: 32276 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220921/690338b7/attachment-0001.bin>


More information about the lldb-commits mailing list