[Lldb-commits] [PATCH] D134252: Track .dwo/.dwp loading errors and notify user when viewing variables.

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1755-1756
         cu_die.GetAttributeValueAsString(dwarf_cu, DW_AT_comp_dir, nullptr);
     if (!comp_dir)
       return nullptr;
 
----------------
yinghuitan wrote:
> We should detect and emit this error as well, like `can't locate <dwo_file> relative to working dir or DW_AT_comp_dir`
I can add this to the error message below yes, good idea.


================
Comment at: lldb/test/API/commands/frame/var/TestFrameVar.py:199
+
+        # self.assertTrue(False, exe)
+        self.assertTrue(os.path.exists(main_dwo), 'Make sure "%s" file exists' % (main_dwo))
----------------
yinghuitan wrote:
> Delete?
yep!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134252/new/

https://reviews.llvm.org/D134252