[Lldb-commits] [PATCH] D134244: [NFCI] Clean up enum FormatCategoryItem.

Tue Sep 20 08:18:46 PDT 2022

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

Makes sense. LGTM modulo the enum values.

================
Comment at: lldb/include/lldb/lldb-private-enumerations.h:131-134
   eFormatCategoryItemSummary = 0x0001,
-  eFormatCategoryItemRegexSummary = 0x0002,
   eFormatCategoryItemFilter = 0x0004,
-  eFormatCategoryItemRegexFilter = 0x0008,
   eFormatCategoryItemSynth = 0x0010,
+  eFormatCategoryItemFormat = 0x0040,
----------------
As these are private we don't have to skip values I think. Also let's use left shift operators to make it more obvious that these are flags.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134244/new/

https://reviews.llvm.org/D134244