[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

Just one nit about double checking if auto deducing is enabled. Fix that and this is good to go.



================
Comment at: lldb/source/Breakpoint/BreakpointResolverFileLine.cpp:305
 
+  if (GetBreakpoint()->GetTarget().GetAutoSourceMapRelative())
+    DeduceSourceMapping(sc_list);
----------------
Either remove this, or leave the check in the DeduceSourceMapping function. I would vote to just always call DeduceSourceMapping in case someone else calls it from anywhere else.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133042/new/

https://reviews.llvm.org/D133042