[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type it has incomplete type debug info.

[Zequan Wu via Phabricator via lldb-commits]

zequanwu created this revision.
zequanwu added reviewers: labath, martong, rnk.
Herald added a subscriber: rnkovacs.
Herald added a project: All.
zequanwu requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

When a record type doesn't have complete type debug info, forcefully complete it
to make clang not crashing at places calling `CXXRecordDecl::data()`.

Here's an example when a class has incomplete type debug info.

  0x17AB1 | LF_CLASS [size = 48] `v8::Data`
            unique name: `.?AVData at v8@@`
            vtable: <no type>, base list: <no type>, field list: <no type>
            options: forward ref (= 0x17AB1) | has unique name, sizeof 0


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D134066

Files:
  lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp
  lldb/test/Shell/SymbolFile/NativePDB/missing-type.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D134066.460854.patch
Type: text/x-patch
Size: 5908 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220916/2e635382/attachment.bin>