[Lldb-commits] [PATCH] D134037: [lldb] Fix CommandInterpreter::DidProcessStopAbnormally() with multiple threads

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Sep 16 12:30:44 PDT 2022


jingham added a comment.

We never made any guarantee about the order threads would be listed in the array returned by GetThreadList.  I'm not sure it would be worth trying to do that, because often you don't know whether a thread's public StopInfo will be valid even if the private stop info is.  For instance, if a thread hits a thread specific breakpoint for a thread that isn't in the breakpoint's thread specifier, then we reset the stop info back to an empty one because formally that thread didn't hit our breakpoint...  So this change is clearly right.

I don't suppose there's a way to write a test for this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134037/new/

https://reviews.llvm.org/D134037



More information about the lldb-commits mailing list