[Lldb-commits] [PATCH] D133858: [lldb] Reset breakpoint hit count before new runs

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Sep 16 10:26:15 PDT 2022


jingham added a comment.

The more we gather up the "things you have to do before an operation starts" or after it ends, etc. into WillDoOperation methods, the less ad hoc code you have in the callers that you have to remember to copy over if you are introducing a different way of doing the same operation.  It also expresses when the operation needs to be done, which if you just had a call out in Process::Attach or whatever you would not know.  Either way will work, but I think packaging these "do before" and "do after" tasks into methods makes everything clearer and easier to maintain.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133858/new/

https://reviews.llvm.org/D133858



More information about the lldb-commits mailing list