[Lldb-commits] [PATCH] D133973: [test] Fix LLDB tests with just-built libcxx when using a target directory.

[Jordan Rupprecht via Phabricator via lldb-commits]

rupprecht added a comment.

In D133973#3793398 <https://reviews.llvm.org/D133973#3793398>, @JDevlieghere wrote:

> Do we need both `LIBCPP_INCLUDE_DIR` and `LIBCPP_INCLUDE_TARGET_DIR`? I see we pass another `-cxx-isystem` flag, does this result in another search path or does that replace the former? If we only need one, we could set `LIBCPP_INCLUDE_DIR` to `libcxx_include_target_dir` or `libcxx_include_dir` respectively.

We need both. `--libcxx_include_dir` sets the regular `include/c++/v1` dir, which contains almost all of libc++ headers. But `__config_site` is separately installed to `include/$TRIPLE/c++/v1`, so without it, all the build steps fail because it can't find `#include <__config_site>`. And `include/$TRIPLE/c++/v1` only contains the `__config_site` file, so we can't use the target dir alone.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133973/new/

https://reviews.llvm.org/D133973