[Lldb-commits] [PATCH] D133944: [lldb][tests][gmodules] Test for expression evaluator crash for types with template base class

[Michael Buch via Phabricator via lldb-commits]

Michael137 created this revision.
Michael137 added reviewers: aprantl, martong.
Herald added a subscriber: rnkovacs.
Herald added a project: All.
Michael137 requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

The problem here is that the ASTImporter adds
the template base class member FieldDecl to
the DeclContext twice. This happens because
we don't construct a `LookupPtr` for decls
that originate from modules and thus the
ASTImporter never realizes that the FieldDecl
has already been imported. These duplicate
decls then break the assumption of the LayoutBuilder
which expects only a single member decl to
exist.

The test will be fixed by a follow-up revision
and is thus skipped for now.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D133944

Files:
  lldb/test/API/lang/cpp/gmodules/base-template-with-same-arg/Makefile
  lldb/test/API/lang/cpp/gmodules/base-template-with-same-arg/TestBaseTemplateWithSameArg.py
  lldb/test/API/lang/cpp/gmodules/base-template-with-same-arg/base_module.cpp
  lldb/test/API/lang/cpp/gmodules/base-template-with-same-arg/base_module.h
  lldb/test/API/lang/cpp/gmodules/base-template-with-same-arg/main.cpp
  lldb/test/API/lang/cpp/gmodules/base-template-with-same-arg/module.modulemap
  lldb/test/API/lang/cpp/gmodules/base-template-with-same-arg/module1.cpp
  lldb/test/API/lang/cpp/gmodules/base-template-with-same-arg/module1.h
  lldb/test/API/lang/cpp/gmodules/base-template-with-same-arg/module2.cpp
  lldb/test/API/lang/cpp/gmodules/base-template-with-same-arg/module2.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133944.460414.patch
Type: text/x-patch
Size: 5905 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220915/a3287745/attachment-0001.bin>