[Lldb-commits] [PATCH] D133858: [lldb] Reset breakpoint hit count before new runs

[Med Ismail Bennani via Phabricator via lldb-commits]

mib added a comment.

In D133858#3790013 <https://reviews.llvm.org/D133858#3790013>, @jingham wrote:

> Resetting the hit counts on rerun is a more useful behavior, so this is all fine.  But the Target is the one that does all the breakpoint management, so I think the resetting should go through the Target, not the Process.  And we generally delegate "do on all breakpoints" operations to the BreakpointList, so it would be more consistent with the current structure to go Process::WillLaunch -> Target::ResetHitCounts -> BreakpointList::ResetHitCounts.

@fdeazeve Pretty cool! But I agree with Jim, breakpoints are handled by the target not the process. As a side-note, in the current implementation, I don't think it's necessary to add the `DoWillAttachToProcessWithID` method and call override it in each process plugin. I think you could have


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133858/new/

https://reviews.llvm.org/D133858