[Lldb-commits] [PATCH] D133906: [lldb] Generate lldb-forward with .def file

[Med Ismail Bennani via Phabricator via lldb-commits]

mib accepted this revision.
mib added a comment.

In D133906#3791153 <https://reviews.llvm.org/D133906#3791153>, @jingham wrote:

> This patch makes me a little sad because it breaks the "Jump to Definition" chain in Xcode (and I bet it does in other IDE's that support this.)  You used to be able to do "Jump to Definition" on ProcessSP, then jump to definition on the class name in the shared pointer definition to jump to the class.  Now the first jump takes you to:
>
> LLDB_FORWARD_CLASS(Process)
>
> in the lldb-forward.def file, and you can't go any further because the IDE can't tell what to do with the contents of the .def file (it has no way to know how it was imported to create real definitions).  These .def insertions almost always make things harder to find in the actual code, so they aren't free.

@jingham to be hosted, as a fellow Xcode user, this indirection annoyed me more than I found it convenient. May be we should have Xcode go directly to the template argument class when jumping to definition on smart pointers.

@jdevlieghere LGTM! Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133906/new/

https://reviews.llvm.org/D133906