[Lldb-commits] [PATCH] D133858: [lldb] Reset breakpoint hit count before new runs

Felipe de Azevedo Piovezan via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Sep 14 08:51:09 PDT 2022


fdeazeve added inline comments.


================
Comment at: lldb/source/Target/Process.cpp:2763-2766
+static void ResetHitCounts(Process &Proc) {
+  for (const auto &BP : Proc.GetTarget().GetBreakpointList().Breakpoints())
+    BP->ResetHitCount();
+}
----------------
JDevlieghere wrote:
> Can this be a private member so we don't have to pass in `*this`? 
No strong preferences on my part, but I had made it a free function because it can be implemented in terms of the public behaviour, i.e. it doesn't rely on implementation details.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133858/new/

https://reviews.llvm.org/D133858



More information about the lldb-commits mailing list