[Lldb-commits] [PATCH] D133045: Partial fix for handling backticks in commands and aliases

[Jim Ingham via Phabricator via lldb-commits]

jingham marked an inline comment as done.
jingham added inline comments.


================
Comment at: lldb/source/Interpreter/Options.cpp:1026
+    } else
+      option_to_insert = CommandInterpreter::g_no_argument;
+
----------------
hawkinsw wrote:
> Question: Could we drop the final `else` if we initialized `option_to_insert` to `CommandInterpreter::g_no_argument`? Just curious. 
No, the correct default when there is an option_arg is the empty string.  So I'd also have to set the string back to empty after the `if (option_arg) {` which would look weird.


================
Comment at: lldb/test/API/commands/command/backticks/TestBackticksInAlias.py:16
+    def test_backticks_in_alias(self):
+        """Test that an alias can contain active backtraces."""
+        self.build()
----------------
hawkinsw wrote:
> Nit: Typo. backtraces => backticks.
Thanks for spotting that, I'll fix on commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133045/new/

https://reviews.llvm.org/D133045