[Lldb-commits] [PATCH] D133446: [LLDB][NativePDB] Global ctor and dtor should be global decls.

Tue Sep 13 08:13:12 PDT 2022

labath added a comment.

In D133446#3780961 <https://reviews.llvm.org/D133446#3780961>, @zequanwu wrote:

> In D133446#3779600 <https://reviews.llvm.org/D133446#3779600>, @labath wrote:
>
>> I believe that this fixes the crash, but the names of generated functions still look fairly weird. Could we create them using their mangled name instead? That way, someone might actually call them, if he was so inclined.
>
> It looks like they don't have mangled name stored in pdb.

Hmm.. That's unfortunate. In that case, I'm wondering if this shouldn't be handled somehow directly inside `MSVCUndecoratedNameParser`. What does the function return right now? Do you think that result is going to be useful for other users of that class?

Also, I'm still continuing to be amazed (and scared) by the amount of name parsing that is going on here. Have you checked that there's no better way to associate an entity with its enclosing context?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133446/new/

https://reviews.llvm.org/D133446