[Lldb-commits] [PATCH] D133623: Fix DW_OP_convert to resolve the CU relative offset correctly.

Mon Sep 12 12:53:24 PDT 2022

aprantl added a comment.

In D133623#3784604 <https://reviews.llvm.org/D133623#3784604>, @clayborg wrote:

> In D133623#3784444 <https://reviews.llvm.org/D133623#3784444>, @aprantl wrote:
>
>> You would need to modify or clone the existing test https://github.com/llvm/llvm-project/blob/38ffa2bb963714cd117b6d4534d328fa6a0fb875/lldb/unittests/Expression/DWARFExpressionTest.cpp#L153 and add a second CU to it. The inlined text is just the output of obj2yaml.
>
> I believe you. The main question is how top get an object file to produce this file in a small and simple test case. Are you saying it would be easy to add another CU by just appending some yaml? Or do I need to come up with a binary first that already has this in two CUs and then try to obj2yaml the binary? If so, please let me know how to make code that does this.

Looking at the test, I think for someone familiar with the DWARF format ;-) manually extending yaml should be pretty straightforward.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133623/new/

https://reviews.llvm.org/D133623