[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

Fri Sep 9 17:40:18 PDT 2022

jasonmolenda added inline comments.

================
Comment at: lldb/source/Plugins/Platform/MacOSX/CMakeLists.txt:47
     lldbUtility
+    lldbPluginDynamicLoaderDarwinKernel
+    lldbPluginObjectContainerMachOFileset
----------------
jasonmolenda wrote:
> thakis wrote:
> > This causes a dependency cycle:
> > 
> >   //lldb/source/Plugins/Platform/MacOSX:MacOSX ->
> >   //lldb/source/Plugins/DynamicLoader/Darwin-Kernel:Darwin-Kernel ->
> >   //lldb/source/Plugins/Platform/MacOSX:MacOSX
> Ach, naturally.  DynamicLoaderDarwinKernel has to create a PlatformDarwinKernel to set in the Target when it is initializing itself.  :/  Maybe I'll just add DynamicLoaderDarwinKernel to the unit tests that have PlatformMacOSX in them.
I removed the dependency in DynamicLoaderDarwinKernel, a very specialized plugin, and left the dependency in PlatformMacOSX which includes all of the darwin platforms and is a common one to import.  I believe any target that is linking against DynamicLoaderDarwinKernel will also have a dependency on PlatformMacOSX already.  I landed this as 30578c08568bc8de79dea72e41f49899ba10ea55 to make sure this causes no problems, we can fix it better if someone has a suggestion.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133534/new/

https://reviews.llvm.org/D133534