[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting() public API

[Greg Clayton via Phabricator via lldb-commits]

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

Just a comment fix and allow the "char" option value to be saved as zero and this will be good to go.



================
Comment at: lldb/include/lldb/API/SBDebugger.h:120-121
+  /// Client can specify empty string or null to get all settings.
+  /// Any setting path that is accepted by "settings show" can be accepted
+  /// here.
+  ///
----------------
This comment is no longer true right? Any setting args that are accepted by settings show not longer is true right? It is just a single setting value you can either specify or not right?


================
Comment at: lldb/include/lldb/Interpreter/OptionValueChar.h:34-37
+    if (m_current_value != '\0')
+      return m_current_value;
+    else
+      return "(null)";
----------------



================
Comment at: lldb/include/lldb/Interpreter/OptionValueChar.h:34-37
+    if (m_current_value != '\0')
+      return m_current_value;
+    else
+      return "(null)";
----------------
yinghuitan wrote:
> clayborg wrote:
> > Since this is actually a character, it should store what ever the character value is. So if the character is zero, it should store zero, not a string "(null)"
> I am not sure about this. This mimics what `OptionValueChar::DumpValue()` does. Do we want to keep consistence here?
if we want to set/restore this value, it should have the correct value. We aren't trying to mimic dump value here. So we should allow it to be set to zero.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133038/new/

https://reviews.llvm.org/D133038