[Lldb-commits] [lldb] c988965 - Temporarily XFAIL libcxx tests.

[Adrian Prantl via lldb-commits]

Author: Adrian Prantl
Date: 2022-09-09T10:43:03-07:00
New Revision: c988965efb2ce8fd867b86d4b893654943d11642

URL: https://github.com/llvm/llvm-project/commit/c988965efb2ce8fd867b86d4b893654943d11642
DIFF: https://github.com/llvm/llvm-project/commit/c988965efb2ce8fd867b86d4b893654943d11642.diff

LOG: Temporarily XFAIL libcxx tests.

These tests started failing on green dragon after a configuration change that compiles tests using the just-built libcxx. We may need to force the system libcxx here, or change LLDB to import the std module from the just-built libcxx, too.

Added: 
    

Modified: 
    lldb/test/API/commands/expression/import-std-module/deque-basic/TestDequeFromStdModule.py
    lldb/test/API/commands/expression/import-std-module/deque-dbg-info-content/TestDbgInfoContentDequeFromStdModule.py
    lldb/test/API/commands/expression/import-std-module/vector-dbg-info-content/TestDbgInfoContentVectorFromStdModule.py
    lldb/test/API/commands/expression/import-std-module/vector/TestVectorFromStdModule.py
    lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/iterator/TestDataFormatterLibccIterator.py
    lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/span/TestDataFormatterLibcxxSpan.py
    lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/string_view/TestDataFormatterLibcxxStringView.py
    lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/variant/TestDataFormatterLibcxxVariant.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/commands/expression/import-std-module/deque-basic/TestDequeFromStdModule.py b/lldb/test/API/commands/expression/import-std-module/deque-basic/TestDequeFromStdModule.py
index 44327c9895d5b..7b514b0c6dd77 100644
--- a/lldb/test/API/commands/expression/import-std-module/deque-basic/TestDequeFromStdModule.py
+++ b/lldb/test/API/commands/expression/import-std-module/deque-basic/TestDequeFromStdModule.py
@@ -10,6 +10,7 @@
 class TestBasicDeque(TestBase):
 
     @add_test_categories(["libc++"])
+    @expectedFailureDarwin
     @skipIf(compiler=no_match("clang"))
     def test(self):
         self.build()

diff  --git a/lldb/test/API/commands/expression/import-std-module/deque-dbg-info-content/TestDbgInfoContentDequeFromStdModule.py b/lldb/test/API/commands/expression/import-std-module/deque-dbg-info-content/TestDbgInfoContentDequeFromStdModule.py
index ff32eed026204..8b98a527c6012 100644
--- a/lldb/test/API/commands/expression/import-std-module/deque-dbg-info-content/TestDbgInfoContentDequeFromStdModule.py
+++ b/lldb/test/API/commands/expression/import-std-module/deque-dbg-info-content/TestDbgInfoContentDequeFromStdModule.py
@@ -10,6 +10,7 @@
 class TestDbgInfoContentDeque(TestBase):
 
     @add_test_categories(["libc++"])
+    @expectedFailureDarwin # FIXME: May need to force system libcxx here.
     @skipIf(compiler=no_match("clang"))
     def test(self):
         self.build()

diff  --git a/lldb/test/API/commands/expression/import-std-module/vector-dbg-info-content/TestDbgInfoContentVectorFromStdModule.py b/lldb/test/API/commands/expression/import-std-module/vector-dbg-info-content/TestDbgInfoContentVectorFromStdModule.py
index c2044ceee778f..8d0e926081661 100644
--- a/lldb/test/API/commands/expression/import-std-module/vector-dbg-info-content/TestDbgInfoContentVectorFromStdModule.py
+++ b/lldb/test/API/commands/expression/import-std-module/vector-dbg-info-content/TestDbgInfoContentVectorFromStdModule.py
@@ -11,6 +11,7 @@
 class TestDbgInfoContentVector(TestBase):
 
     @add_test_categories(["libc++"])
+    @expectedFailureDarwin # FIXME: May need to force system libcxx here.
     @skipIf(compiler=no_match("clang"))
     def test(self):
         self.build()

diff  --git a/lldb/test/API/commands/expression/import-std-module/vector/TestVectorFromStdModule.py b/lldb/test/API/commands/expression/import-std-module/vector/TestVectorFromStdModule.py
index 59b3e4f71ad7c..44bee3df614c6 100644
--- a/lldb/test/API/commands/expression/import-std-module/vector/TestVectorFromStdModule.py
+++ b/lldb/test/API/commands/expression/import-std-module/vector/TestVectorFromStdModule.py
@@ -10,6 +10,7 @@
 class TestBasicVector(TestBase):
 
     @add_test_categories(["libc++"])
+    @expectedFailureDarwin # FIXME: May need to force system libcxx here.
     @skipIf(compiler=no_match("clang"))
     def test(self):
         self.build()

diff  --git a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/iterator/TestDataFormatterLibccIterator.py b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/iterator/TestDataFormatterLibccIterator.py
index 55db9c2051cca..b6682e5c7e930 100644
--- a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/iterator/TestDataFormatterLibccIterator.py
+++ b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/iterator/TestDataFormatterLibccIterator.py
@@ -19,6 +19,7 @@ def setUp(self):
         self.line = line_number('main.cpp', '// Set break point at this line.')
         self.namespace = 'std'
 
+    @expectedFailureDarwin # FIXME: May need to force system libcxx here.
     @add_test_categories(["libc++"])
     def test_with_run_command(self):
         """Test that libc++ iterators format properly."""

diff  --git a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/span/TestDataFormatterLibcxxSpan.py b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/span/TestDataFormatterLibcxxSpan.py
index 3236544e21859..6d78659d43f45 100644
--- a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/span/TestDataFormatterLibcxxSpan.py
+++ b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/span/TestDataFormatterLibcxxSpan.py
@@ -43,6 +43,7 @@ def check_numbers(self, var_name):
         self.expect_var_path(f'{var_name}[4]', type='int', value='12345')
 
     @add_test_categories(['libc++'])
+    @expectedFailureDarwin # FIXME: May need to force system libcxx here.
     @skipIf(compiler='clang', compiler_version=['<', '11.0'])
     def test_with_run_command(self):
         """Test that std::span variables are formatted correctly when printed."""

diff  --git a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/string_view/TestDataFormatterLibcxxStringView.py b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/string_view/TestDataFormatterLibcxxStringView.py
index db82e7c65e033..1090e6c60c202 100644
--- a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/string_view/TestDataFormatterLibcxxStringView.py
+++ b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/string_view/TestDataFormatterLibcxxStringView.py
@@ -21,6 +21,7 @@ def setUp(self):
         self.line2 = line_number('main.cpp', '// Break here to look at bad string view.' )
 
     @add_test_categories(["libc++"])
+    @expectedFailureDarwin # FIXME: May need to force system libcxx here.
     @expectedFailureAll(bugnumber="llvm.org/pr36109", debug_info="gmodules", triple=".*-android")
     # Inline namespace is randomly ignored as Clang due to broken lookup inside
     # the std namespace.

diff  --git a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/variant/TestDataFormatterLibcxxVariant.py b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/variant/TestDataFormatterLibcxxVariant.py
index 27724b25ae54e..9cb36e41c7326 100644
--- a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/variant/TestDataFormatterLibcxxVariant.py
+++ b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/variant/TestDataFormatterLibcxxVariant.py
@@ -19,7 +19,7 @@ class LibcxxVariantDataFormatterTestCase(TestBase):
     @skipIf(compiler="gcc", compiler_version=['<', '5.1'])
     ## std::get is unavailable for std::variant before macOS 10.14
     @skipIf(macos_version=["<", "10.14"])
-
+    @expectedFailureDarwin # FIXME: May need to force system libcxx here.
     def test_with_run_command(self):
         """Test that that file and class static variables display correctly."""
         self.build()