[Lldb-commits] [PATCH] D133525: fix extra bytes when compressing for 32bit objcopy

[Fangrui Song via Phabricator via lldb-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/ObjCopy/ELF/ELFObjcopy.cpp:509
+  const ElfType OutputElfType =
+      getOutputElfType(Config.OutputArch.value_or(MachineInfo()));
+  const bool Is64Bit =
----------------
This is incorrect. Config.OutputArch is usually unset (`-O`).

We need a field in `Object` and initialize it in `llvm/lib/ObjCopy/ELF/ELFObject.cpp:1883`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133525/new/

https://reviews.llvm.org/D133525