[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting() public API

Thu Sep 8 20:59:51 PDT 2022

hawkinsw added inline comments.

================
Comment at: lldb/test/API/functionalities/source-map/TestTargetSourceMap.py:25
+        src_dir = self.getSourceDir()
+        self.runCmd('settings set target.source-map . "%s"' % src_dir)
+
----------------
yinghuitan wrote:
> hawkinsw wrote:
> > Sorry if this comment is not helpful, but I was wondering ...
> > 
> > Could we use `source_map_setting_path` here? That would make future changes easier?
> @hawkinsw, sorry, almost missed your comment. There is no single value for source map path but a pair of original/replacement. In this case, original is "." while the replacement is "src_dir" so I think src_dir makes sense here. 
No problem! I am sorry I miscommunicated! I just meant, could we write something like

```
self.runCmd('settings set %s . "%s"' % (source_map_setting_path, src_dir))
```

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133038/new/

https://reviews.llvm.org/D133038