[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting()/GetSettings() public APIs

Will Hawkins via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Sep 8 17:44:27 PDT 2022


hawkinsw added inline comments.


================
Comment at: lldb/test/API/functionalities/source-map/TestTargetSourceMap.py:25
+        src_dir = self.getSourceDir()
+        self.runCmd('settings set target.source-map . "%s"' % src_dir)
+
----------------
Sorry if this comment is not helpful, but I was wondering ...

Could we use `source_map_setting_path` here? That would make future changes easier?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133038/new/

https://reviews.llvm.org/D133038



More information about the lldb-commits mailing list