[Lldb-commits] [PATCH] D133129: [lldb] Add boilerplate for debugger interrupts

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

I don't know how this is intended to be used, but I find it a rather heavyweight approach towards implementing, well... anything. The idea that something as innocuous as SBAddress::IsValid() will end up iterating through _all_ SBDebugger objects seems wrong, regardless of whether it has a measurable performance impact (and I'd be surprised if it doesn't). I'd hope that the interrupter can at least know which debugger it is trying to interrupt.

It's also not clear how something like this can be used to reliably interrupt an activity, as it's prone to all sorts of race conditions. (If the interuptee has not started the blocking call yet, then the interrupt request can be "eaten" by an innocuous IsValid call, whereas if it has already finished, then the interrupt request can remain pending and interrupt a totally unrelated call).

Overall, I think it would be good to have a RFC on this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133129/new/

https://reviews.llvm.org/D133129