[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

Tue Sep 6 23:19:01 PDT 2022

labath added inline comments.

================
Comment at: lldb/test/API/commands/expression/fixits/TestFixIts.py:54
+        # FIXME: LLDB struggles with this when stdlib has debug info.
+        if not lldbutil.has_debug_info_in_libcxx(target):
+            self.assertEquals(value.GetError().GetCString(), "error: No value")
----------------
What kind of error are you getting here? Are you sure this is not some form of https://github.com/llvm/llvm-project/issues/34391, which could be worked around by renaming some variables in the expression?

================
Comment at: lldb/test/API/commands/expression/import-std-module/forward_list-dbg-info-content/TestDbgInfoContentForwardListFromStdModule.py:35
         # FIXME: The value here isn't actually empty.
-        self.expect_expr("a.front()",
-                         result_type=value_type,
-                         result_children=[ValueCheck()])
+        # FIXME: LLDB struggles with this when stdlib has debug info.
+        if not lldbutil.has_debug_info_in_libcxx(target):
----------------
And here it might be better to just remove the check, as it's checking for buggy behavior anyway.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132940/new/

https://reviews.llvm.org/D132940