[Lldb-commits] [PATCH] D133393: [test] Use localhost in place of 127.0.0.1 to run in ipv6-only environments.

Jordan Rupprecht via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Sep 6 19:23:05 PDT 2022


rupprecht added a comment.

I previously converted some tests to support running in ipv6-only environments in D87333 <https://reviews.llvm.org/D87333>, but we weren't running these tests so I missed them. Looking at history, I see D58131 <https://reviews.llvm.org/D58131> specifically changed this from localhost to 127.0.0.1. Do the reasons there still apply today? I could make this more complicated and probe to see if `127.0.0.1` is supported, and fallback to `::1` if that doesn't work, like I did in parts of D87333 <https://reviews.llvm.org/D87333>, although this would be preferred IMO.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133393/new/

https://reviews.llvm.org/D133393



More information about the lldb-commits mailing list