[Lldb-commits] [PATCH] D133243: [LLDB][NativePDB] Fix PdbAstBuilder::GetParentDeclContextForSymbol when ICF happens.

Zequan Wu via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Sep 6 15:43:11 PDT 2022


zequanwu updated this revision to Diff 458299.
zequanwu added a comment.

- Removed `GetParentDeclContextForSymbol` as this is not necesssary. We can get the demangled names from CVSymbol and then using it to create tag decl or namespace decl.
- Add test cases with same base names, but with different namespace/class.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133243/new/

https://reviews.llvm.org/D133243

Files:
  lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp
  lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.h
  lldb/test/Shell/SymbolFile/NativePDB/icf.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133243.458299.patch
Type: text/x-patch
Size: 7503 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220906/13e7cbc9/attachment-0001.bin>


More information about the lldb-commits mailing list