[Lldb-commits] [PATCH] D133352: [lldb-server] Report launch error in vRun packets

[Jordan Rupprecht via Phabricator via lldb-commits]

rupprecht requested changes to this revision.
rupprecht added inline comments.
This revision now requires changes to proceed.


================
Comment at: lldb/source/Host/posix/ProcessLauncherPosixFork.cpp:293
+    r = llvm::sys::RetryAfterSignal(-1, read, pipe.GetReadFileDescriptor(), pos,
+                                    buf.end() - pos);
+  } while (r > 0);
----------------
IIUC, this will overrun the buffer if there are >1000 bytes to read; whereas previously we just wouldn't have read everything.

Should each loop iteration grow the buffer by a certain amount? Otherwise I think we need to remove the loop.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133352/new/

https://reviews.llvm.org/D133352