[Lldb-commits] [PATCH] D133251: [lldb] [Core] Split read thread support into ThreadedCommunication

[Dave Lee via Phabricator via lldb-commits]

kastiglione added a comment.
Herald added a subscriber: JDevlieghere.

> `CommunicationKDP` is updated in order to (hopefully) compile with the new code. However, I do not have a Darwin box to test it, so I've limited the changes to the bare minimum.

Compilation fails:

  /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp:232:47: error: unknown type name 'm_bytes_mutex'
    std::lock_guard<std::recursive_mutex> guard(m_bytes_mutex);

Should we revert?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133251/new/

https://reviews.llvm.org/D133251