[Lldb-commits] [PATCH] D132578: [lldb] [Core] Use thread for Communication::Write() as well

Mon Sep 5 06:02:31 PDT 2022

labath added a comment.

In D132578#3769078 <https://reviews.llvm.org/D132578#3769078>, @mgorny wrote:

> Ok, so I guess I'm back the original plan of using async thread to do the packet exchanges. Right now, the rough plan is to:
>
> 1. Try to clean up / streamline the comms API a bit.
> 2. Introduce a wrapper between the client and the actual comms to clearly split the public packet exchange API from the actual comms. Initially, the wrapper will just call into the comm methods.
> 3. Add the "new" async thread to the wrapper. The actual comms will be performed by the thread, and the wrapper will communicate with it.
> 4. Add support for sharing the wrapper between multiple process instances, and using the comm thread from multiple processes simultaneously.
>
> Exact details TBD. It's possible that initially I'll leave the per-process "old" async threads as well in order to reduce the diffs.

Seems reasonable. Just be aware that the packet RTT is very important for some, so we will either make sure that the extra thread is not used in the base case (no processes running), or somehow ensure that the extra thread does not introduce delays.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132578/new/

https://reviews.llvm.org/D132578