[Lldb-commits] [PATCH] D133240: [Formatters][NFCI] Replace 'is_regex' arguments with an enum.

[Will Hawkins via Phabricator via lldb-commits]

hawkinsw added inline comments.


================
Comment at: lldb/include/lldb/DataFormatters/FormattersContainer.h:46
   /// just matching by comparing with m_type_name string.
-  bool m_is_regex;
+  lldb::FormatterMatchType m_match_type;
 
----------------
I am really intrigued by this entire patchset and just wanted to drop by to help, if I could. I hope that I am not upsetting you by commenting on something so trivial, but it seems like we would want to change the comment for this data member while we are at it?

Again, I think this work is great and I hope I am helping!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133240/new/

https://reviews.llvm.org/D133240