[Lldb-commits] [lldb] d46ea78 - [LLDB] Simplify cmake for instruction emulation unit tests

[David Spickett via lldb-commits]

Author: David Spickett
Date: 2022-09-01T09:40:04Z
New Revision: d46ea783e6fad5d92f9f0aaa96f979ca826403e3

URL: https://github.com/llvm/llvm-project/commit/d46ea783e6fad5d92f9f0aaa96f979ca826403e3
DIFF: https://github.com/llvm/llvm-project/commit/d46ea783e6fad5d92f9f0aaa96f979ca826403e3.diff

LOG: [LLDB] Simplify cmake for instruction emulation unit tests

I got suspicious because of checking "ARM" for an "ARM64" plugin.
As far as I can tell these never needed an llvm target to function.

Looking at the corresponding cmake for the libraries under test they
don't reference target libraries either.

Reviewed By: labath

Differential Revision: https://reviews.llvm.org/D133024

Added: 
    

Modified: 
    lldb/unittests/Instruction/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/lldb/unittests/Instruction/CMakeLists.txt b/lldb/unittests/Instruction/CMakeLists.txt
index c02afe95617eb..1d011d5f7c5b8 100644
--- a/lldb/unittests/Instruction/CMakeLists.txt
+++ b/lldb/unittests/Instruction/CMakeLists.txt
@@ -1,29 +1,14 @@
-set(FILES "")
-set(DEPS "")
-
-if ("ARM" IN_LIST LLVM_TARGETS_TO_BUILD)
-  list(APPEND FILES ARM64/TestAArch64Emulator.cpp)
-  list(APPEND DEPS lldbPluginInstructionARM64)
-endif ()
-
-if ("RISCV" IN_LIST LLVM_TARGETS_TO_BUILD)
-  list(APPEND FILES RISCV/TestRISCVEmulator.cpp)
-  list(APPEND DEPS lldbPluginInstructionRISCV)
-endif ()
-
-list(LENGTH FILES LISTLEN)
-
-if (LISTLEN GREATER 0)
-  add_lldb_unittest(EmulatorTests
-    ${FILES}
-
-    LINK_LIBS
-      lldbCore
-      lldbSymbol
-      lldbTarget
-      ${DEPS}
-    LINK_COMPONENTS
-      Support
-      ${LLVM_TARGETS_TO_BUILD}
-    )
-endif ()
+add_lldb_unittest(EmulatorTests
+  ARM64/TestAArch64Emulator.cpp
+  RISCV/TestRISCVEmulator.cpp
+
+  LINK_LIBS
+    lldbCore
+    lldbSymbol
+    lldbTarget
+    lldbPluginInstructionARM64
+    lldbPluginInstructionRISCV
+
+  LINK_COMPONENTS
+    Support
+  )
\ No newline at end of file