[Lldb-commits] [PATCH] D133069: Fix inconsistent target arch when attaching to arm64 binaries on arm64e platforms.

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp:584
+        triple.setArchName("arm64");
+        target_arch.SetTriple(triple);
+        target.SetArchitecture(target_arch, /*set_platform=*/false,
----------------
aprantl wrote:
> JDevlieghere wrote:
> > Why can't you set the `target_arch` to `exe_module_sp->GetArchitecture().GetTriple()`? 
> That would be shorter. I was worried that could undo any mac catalyst versus macos fixups we did in DynamicLinkerDarwin before.
Fair enough. Can we at least take the architecture from the triple then and pass that instead of hardcoding `arm64`? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133069/new/

https://reviews.llvm.org/D133069