[Lldb-commits] [PATCH] D133075: Fix lldb-dotest when dotest_args_str is empty

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Aug 31 17:49:11 PDT 2022


jingham updated this revision to Diff 457138.
jingham added a comment.

This one actually works.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133075/new/

https://reviews.llvm.org/D133075

Files:
  lldb/utils/lldb-dotest/lldb-dotest.in


Index: lldb/utils/lldb-dotest/lldb-dotest.in
===================================================================
--- lldb/utils/lldb-dotest/lldb-dotest.in
+++ lldb/utils/lldb-dotest/lldb-dotest.in
@@ -16,7 +16,11 @@
 
 if __name__ == '__main__':
     wrapper_args = sys.argv[1:]
-    dotest_args = dotest_args_str.split(';')
+    dotest_args = []
+    # split on an empty string will produce [''] and if you
+    # add that to the command, it will be treated as a directory...
+    if len(dotest_args_str) > 0:
+        dotest_args = dotest_args_str.split(';')
     # Build dotest.py command.
     cmd = [sys.executable, dotest_path]
     cmd.extend(['--arch', arch])


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133075.457138.patch
Type: text/x-patch
Size: 668 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220901/aff03af1/attachment.bin>


More information about the lldb-commits mailing list