[Lldb-commits] [PATCH] D133045: Partial fix for handling backticks in commands and aliases

[Will Hawkins via Phabricator via lldb-commits]

hawkinsw added a comment.

Sorry if these comments are not helpful! Everything looks great!



================
Comment at: lldb/source/Interpreter/Options.cpp:1026
+    } else
+      option_to_insert = CommandInterpreter::g_no_argument;
+
----------------
Question: Could we drop the final `else` if we initialized `option_to_insert` to `CommandInterpreter::g_no_argument`? Just curious. 


================
Comment at: lldb/test/API/commands/command/backticks/TestBackticksInAlias.py:16
+    def test_backticks_in_alias(self):
+        """Test that an alias can contain active backtraces."""
+        self.build()
----------------
Nit: Typo. backtraces => backticks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133045/new/

https://reviews.llvm.org/D133045