[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

Wed Aug 31 07:26:36 PDT 2022

labath added a comment.

In D132940#3761082 <https://reviews.llvm.org/D132940#3761082>, @fdeazeve wrote:

> In D132940#3761038 <https://reviews.llvm.org/D132940#3761038>, @labath wrote:
>
>>> Cross-platform (such as API/macosx/macCatalyst and API/tools/lldb-server).
>>
>> What makes these two tests special?
>
> These two tests are _always_ building binaries for Mac Catalyst (API/macosx/macCatalyst), and watchOS/iOS Simulator (API/tools/lldb-server/TestAppleSimulatorOSType.py).

Ok, that makes more sense. I was confused because the Makefile in `lldb/test/API/tools/lldb-server` is used by (a lot) more tests than just TestAppleSimulatorOSType. In that case, I would say that this argument should be passed directly from python, as a part of the `self.build` command (the test already passes a bunch of arguments there anyway).

================
Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:381-386
+ifneq ($(and $(USE_LIBSTDCPP), $(USE_LIBCPP)),)
+	$(error Libcxx and Libstdc++ cannot be used together)
+endif
+
+ifeq (1, $(USE_SYSTEM_STDLIB))
+	ifneq ($(or $(USE_LIBSTDCPP), $(USE_LIBCPP)),)
----------------
Instead of three distinct variables, it might be nicer to just have one argument (STDLIB_KIND ?) which can take three different values...

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132940/new/

https://reviews.llvm.org/D132940