[Lldb-commits] [PATCH] D132954: lldb: Add support for R_386_32 relocations to ObjectFileELF

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

In D132954#3758856 <https://reviews.llvm.org/D132954#3758856>, @dmlary wrote:

> I'm looking for any suggestions of how to test this.  I can create a simple object file with the needed relocation types with yaml2obj, but I don't see an easy way to get lldb to apply those relocations (in .`.text` for example).

IIRC, lldb explicitly skips any relocations on non-debug sections. Could you check if the relocations are being reflected in the output of `lldb-test object-file --contents %t`? If so, then you could use that command to print the contents of a dummy debug info section (it doesn't even have to be valid DWARF).



================
Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2650
+                                 reloc_type(rel));
         assert(false && "unexpected relocation type");
       }
----------------
Maybe just remove this assertion now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132954/new/

https://reviews.llvm.org/D132954