[Lldb-commits] [PATCH] D132642: [lldb] Fix dotest argument order

[Felipe de Azevedo Piovezan via Phabricator via lldb-commits]

fdeazeve added inline comments.


================
Comment at: lldb/test/API/CMakeLists.txt:166
 
+set(LLDB_TEST_COMMON_ARGS ${LLDB_TEST_COMMON_ARGS_VAR} CACHE INTERNAL STRING)
+
----------------
JDevlieghere wrote:
> Instead of having two variables, why not move this to line 40 and make `LLDB_TEST_COMMON_ARGS` a cached variable and operate directly on that? 
I actually address this in the commit message:

> The variable LLDB_TEST_COMMON_ARGS needs to be a CACHE property, but it
is modified throughout the CMake file with set or list or string
commands, which don't work with properties. As such, a temporary
variable LLDB_TEST_COMMON_ARGS_VAR is created.

Does this make sense?


================
Comment at: lldb/test/API/lit.site.cfg.py.in:26
+config.dotest_common_args_str = lit_config.substitute("@LLDB_TEST_COMMON_ARGS@")
+config.dotest_user_cmake_args_str = lit_config.substitute("@LLDB_TEST_USER_ARGS@")
 config.lldb_enable_python = @LLDB_ENABLE_PYTHON@
----------------
JDevlieghere wrote:
> Let's omit the `cmake` part, it doesn't really matter where these args come from. 
Agreed!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132642/new/

https://reviews.llvm.org/D132642