[Lldb-commits] [PATCH] D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`

[Chuanqi Xu via Phabricator via lldb-commits]

ChuanqiXu added a comment.

In D132624#3748434 <https://reviews.llvm.org/D132624#3748434>, @avogelsgesang wrote:

>> The only concern is that if it would be not so easy to read if there are too many levels? (Consider the 30levels example in D132451 <https://reviews.llvm.org/D132451>). If it would be better to print ... at certain level? Or this is already handled by lldb?
>
> Agree, it would be better to limit the printing at some point. However, afaict, limiting the depth to which children are expanded cannot be done from inside the data formatter/synthetic children frontend. I am not sure if lldb already has a separate mechanism in place to limit printing in this case. If it does not, I think it makes sense to add it, but that would be a separate commit

Yeah, I am not objecting this. I understand it is bad to make perfect the enemy of better.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132624/new/

https://reviews.llvm.org/D132624