[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

Wed Aug 24 13:43:59 PDT 2022

jasonmolenda added a comment.

In D132510#3745412 <https://reviews.llvm.org/D132510#3745412>, @kasper81 wrote:

> @jasonmolenda the problem with original review is that we were waiting for the wholesale support for 3.5 years, and it rendered into an impossible task for the author. I don't want to make this one "all or none" kind of a deal as well. This patch is neither bringing 100% lldb support nor regressing. It is an incremental step forward to unblock a few more scenarios to initialize SysV ABI.

Perfectly reasonable.  I don't have any problems with this patch, but you might want to add a little FIXME comment in CreateDefaultUnwindPlan noting that it should create a frame-pointer-based unwind plan a la any of the ARM ABI plugins, that this unwind plan is only correct on the first instruction or a leaf function that does not set up a stack frame.  I'd also duplicate that method under the name CreateFunctionEntryUnwindPlan() because I believe this is a correct implementation of that ABI method.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132510/new/

https://reviews.llvm.org/D132510