[Lldb-commits] [PATCH] D132415: [LLDB] Add data formatter for std::coroutine_handle

[Jim Ingham via Phabricator via lldb-commits]

jingham added inline comments.


================
Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/coroutine_handle/TestCoroutineHandle.py:15
+
+class TestCoroutineHandle(TestBase):
+    def do_test(self, stdlib_type):
----------------
aprantl wrote:
> Nice test!
Would you mind changing moving this into lldbutil.py?  This seems generally useful.  If you return the thread & breakpoint it would be even more generally useful?


================
Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/coroutine_handle/TestCoroutineHandle.py:44
+
+        lldbutil.run_to_source_breakpoint(self, '// Break after co_yield',
+                lldb.SBFileSpec("main.cpp", False))
----------------
avogelsgesang wrote:
> aprantl wrote:
> > Does this launch a new process? It might be faster to just set an additional breakpoint and run `process.Continue()`.
> somehow, I assumed `run_to_source_breakpoint` would actually continue the running process instead of starting a new process. But looking into `run_to_source_breakpoint`, you are right, this launches a new process...
> 
> I changed this to instead continue execution of the already launched process
There is also lldbutil.continue_to_breakpoint,


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132415/new/

https://reviews.llvm.org/D132415