[Lldb-commits] [PATCH] D132415: [LLDB] Add data formatter for std::coroutine_handle

[Chuanqi Xu via Phabricator via lldb-commits]

ChuanqiXu added a reviewer: dblaikie.
ChuanqiXu added a comment.

LGTM. But I am not familiar with debugger internals. So I'll leave the formal acceptance for other reviewers.



================
Comment at: lldb/source/Plugins/Language/CPlusPlus/Coroutines.cpp:138
+}
\ No newline at end of file

----------------
Add the new line.


================
Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.h:62-64
+bool LibcxxUniquePointerSummaryProvider(
+    ValueObject &valobj, Stream &stream,
+    const TypeSummaryOptions &options); // libc++ std::unique_ptr<>
----------------
Unrelated change? Generally we could do this in a separate NFC patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132415/new/

https://reviews.llvm.org/D132415