[Lldb-commits] [PATCH] D132382: [lldb] Remove prefer-dynamic-value test override

[Dave Lee via Phabricator via lldb-commits]

kastiglione created this revision.
kastiglione added reviewers: augusto2112, JDevlieghere, mib, aprantl.
Herald added a project: All.
kastiglione requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

Remove the test override of `target.prefer-dynamic-value`.

Previously, the lldb default was `no-dynamic-values`. In rG9aa7e8e9ffbe <https://reviews.llvm.org/rG9aa7e8e9ffbef6989fa9aeb4e06fe8b0c38a75b7> (in
2015), the default was changed to `no-run-target`, but at that time the tests
were changed to be run with `no-dynamic-value`. I don't the reasons for not
changing the tests, perhaps to avoid determining which tests to change and how.

Because `no-run-target` is the lldb default, I think it makes sense to make it
the test default too. It puts the test config closer to what's used in
practice.

This change removes the `target.prefer-dynamic-value` override, and for those
tests that failed, they have been updated to explicitly use
`no-dynamic-values`. Future changes could update these tests to use dynamic
values too, or they can be left as is to exercise non-dynamic typing.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D132382

Files:
  lldb/packages/Python/lldbsuite/test/configuration.py
  lldb/test/API/commands/expression/po_verbosity/TestPoVerbosity.py
  lldb/test/API/commands/expression/two-files/TestObjCTypeQueryFromOtherCompileUnit.py
  lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCCF.py
  lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCExpr.py
  lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCKVO.py
  lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSContainer.py
  lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSData.py
  lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSNumber.py
  lldb/test/API/functionalities/data-formatter/data-formatter-objc/nsstring/TestDataFormatterNSString.py
  lldb/test/API/functionalities/data-formatter/nsarraysynth/TestNSArraySynthetic.py
  lldb/test/API/functionalities/data-formatter/nsdictionarysynth/TestNSDictionarySynthetic.py
  lldb/test/API/lang/cpp/diamond/TestCppDiamond.py
  lldb/test/API/lang/objc/blocks/TestObjCIvarsInBlocks.py
  lldb/test/API/lang/objc/exceptions/TestObjCExceptions.py
  lldb/test/API/lang/objc/foundation/TestObjCMethods.py
  lldb/test/API/lang/objc/foundation/TestObjCMethodsString.py
  lldb/test/API/lang/objc/foundation/TestRuntimeTypes.py
  lldb/test/API/lang/objc/objc-new-syntax/TestObjCNewSyntaxLiteral.py
  lldb/test/API/lang/objc/real-definition/TestRealDefinition.py
  lldb/test/API/sanity/TestSettingSkipping.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D132382.454526.patch
Type: text/x-patch
Size: 16919 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220822/d19de3be/attachment.bin>