[Lldb-commits] [PATCH] D132353: [LLDB] Fix: make m_target_arch private

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added inline comments.


================
Comment at: lldb/source/Plugins/Process/Utility/RegisterContextFreeBSD_powerpc.cpp:227
 const RegisterInfo *RegisterContextFreeBSD_powerpc64::GetRegisterInfo() const {
   // assert (m_target_arch.GetCore() == ArchSpec::eCore_powerpc);
+  if (GetTargetArchitecture().GetMachine() == llvm::Triple::ppc)
----------------
Please also remove the commented out asserts that use `m_target_arch`.

At least for PowerPC they have been commented out since the first commit so it won't do any harm to remove them and they will now fail to compile anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132353/new/

https://reviews.llvm.org/D132353