[Lldb-commits] [PATCH] D132191: Treat a UUID of all zeros consistently to mean "Invalid UUID"

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Aug 22 01:12:03 PDT 2022


labath accepted this revision.
labath added inline comments.


================
Comment at: lldb/include/lldb/Utility/UUID.h:47
+  /// Creates a UUID from the data pointed to by the bytes argument. 
   static UUID fromData(const void *bytes, uint32_t num_bytes) {
     if (bytes)
----------------
The main reason this was a factory function was so that we could use the factory name to disambiguate between the two interpretations of zero "uuids".

As we're removing that, we could also go back to using regular constructors for object creation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132191/new/

https://reviews.llvm.org/D132191



More information about the lldb-commits mailing list