[Lldb-commits] [PATCH] D132217: [lldb] [Core] Harmonize Communication::Read() returns w/ thread

Mon Aug 22 00:51:03 PDT 2022

labath added a comment.

In D132217#3735180 <https://reviews.llvm.org/D132217#3735180>, @mgorny wrote:

> @labath, any chance you could take a look at the failures on Windows? I'm wondering if this is because "pipes don't work like that on Windows" or if there's a way to make them work. For now I'm just going to skip these tests on win32.
>
> https://lab.llvm.org/buildbot/#/builders/83/builds/22672

I'm not sure why the first write fails, but I believe that even if we fixed that, that we would have problems with the read operation, as the pipe FD will not work with select. I think the safest/simplest way to fix this would be to change the test to use sockets instead.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132217/new/

https://reviews.llvm.org/D132217