[Lldb-commits] [PATCH] D124314: lldb: Disable unittests if llvm_gtest target does not exist

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/CMakeLists.txt:128
+set(LLDB_INCLUDE_UNITTESTS ON)
+if (NOT TARGET llvm_gtest)
+  set(LLDB_INCLUDE_UNITTESTS OFF)
----------------
mgorny wrote:
> If LLDB is built through `LLVM_ENABLE_PROJECTS`, then LLDB's CMakeLists are included before the subdirectory containing `llvm_gtest`, effectively making this condition always false.
Good catch. I've put up https://reviews.llvm.org/D131861 as a (straw man) proposal. But I haven't tested it yet.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124314/new/

https://reviews.llvm.org/D124314