[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

Med Ismail Bennani via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 12 14:01:48 PDT 2022


mib accepted this revision.
mib added a comment.

LGTM with @teemperor feedback !



================
Comment at: lldb/test/API/macosx/queues/TestQueues.py:131
+                         "The breakpoint was set for queue %s, but the breakpoint's queue name is %s" % (queue_breakpoint.GetQueueName(), queue1.GetName()))
+        self.assertTrue(queue_breakpoint.GetHitCount() == 1,
+                        "The breakpoint for queue %s has not been hit" % (queue_breakpoint.GetQueueName()))
----------------
teemperor wrote:
> missed assertEqual here?
+1!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131605/new/

https://reviews.llvm.org/D131605



More information about the lldb-commits mailing list