[Lldb-commits] [PATCH] D131741: [lldb] XFAIL target variable tests on Intel/Darwin when using Xcode 14

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere updated this revision to Diff 452045.
JDevlieghere added a comment.

Check the darwin OS version as a proxy for the deployment target


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131741/new/

https://reviews.llvm.org/D131741

Files:
  lldb/test/API/commands/target/basic/TestTargetCommand.py
  lldb/test/API/lang/c/global_variables/TestGlobalVariables.py
  lldb/test/API/lang/cpp/char8_t/TestCxxChar8_t.py


Index: lldb/test/API/lang/cpp/char8_t/TestCxxChar8_t.py
===================================================================
--- lldb/test/API/lang/cpp/char8_t/TestCxxChar8_t.py
+++ lldb/test/API/lang/cpp/char8_t/TestCxxChar8_t.py
@@ -12,8 +12,10 @@
 
 class CxxChar8_tTestCase(TestBase):
 
+    # Chained Fixups
+    @expectedFailureDarwin(archs=["arm64", "arm64e"])
+    @expectedFailureDarwin(archs=['x86_64'], macos_version=[">=", "13.0"])
     @skipIf(compiler="clang", compiler_version=['<', '7.0'])
-    @expectedFailureDarwin(archs=["arm64", "arm64e"]) # <rdar://problem/37773624>
     def test_without_process(self):
         """Test that C++ supports char8_t without a running process."""
         self.build()
Index: lldb/test/API/lang/c/global_variables/TestGlobalVariables.py
===================================================================
--- lldb/test/API/lang/c/global_variables/TestGlobalVariables.py
+++ lldb/test/API/lang/c/global_variables/TestGlobalVariables.py
@@ -18,8 +18,10 @@
             self.source, '// Set break point at this line.')
         self.shlib_names = ["a"]
 
+    # Chained Fixups
+    @expectedFailureDarwin(archs=["arm64", "arm64e"])
+    @expectedFailureDarwin(archs=['x86_64'], macos_version=[">=", "13.0"])
     @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24764")
-    @expectedFailureDarwin(archs=["arm64", "arm64e"]) # <rdar://problem/37773624>
     def test_without_process(self):
         """Test that static initialized variables can be inspected without
         process."""
Index: lldb/test/API/commands/target/basic/TestTargetCommand.py
===================================================================
--- lldb/test/API/commands/target/basic/TestTargetCommand.py
+++ lldb/test/API/commands/target/basic/TestTargetCommand.py
@@ -42,7 +42,9 @@
         self.buildAll()
         self.do_target_command()
 
-    @expectedFailureDarwin(archs=["arm64", "arm64e"]) # <rdar://problem/37773624>
+    # Chained Fixups
+    @expectedFailureDarwin(archs=["arm64", "arm64e"])
+    @expectedFailureDarwin(archs=['x86_64'], macos_version=[">=", "13.0"])
     def test_target_variable_command(self):
         """Test 'target variable' command before and after starting the inferior."""
         d = {'C_SOURCES': 'globals.c', 'EXE': self.getBuildArtifact('globals')}
@@ -51,7 +53,9 @@
 
         self.do_target_variable_command('globals')
 
-    @expectedFailureDarwin(archs=["arm64", "arm64e"]) # <rdar://problem/37773624>
+    # Chained Fixups
+    @expectedFailureDarwin(archs=["arm64", "arm64e"])
+    @expectedFailureDarwin(archs=['x86_64'], macos_version=[">=", "13.0"])
     def test_target_variable_command_no_fail(self):
         """Test 'target variable' command before and after starting the inferior."""
         d = {'C_SOURCES': 'globals.c', 'EXE': self.getBuildArtifact('globals')}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131741.452045.patch
Type: text/x-patch
Size: 2859 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220812/b224809f/attachment-0001.bin>