[Lldb-commits] [PATCH] D131086: [lldb/crashlog] Improve exception reporting for interactive mode

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGTM assuming this compiles on non-apple hosts



================
Comment at: lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp:525-542
+  case EXC_BAD_ACCESS:
+    return "EXC_BAD_ACCESS";
+  case EXC_BAD_INSTRUCTION:
+    return "EXC_BAD_INSTRUCTION";
+  case EXC_ARITHMETIC:
+    return "EXC_ARITHMETIC";
+  case EXC_EMULATION:
----------------
mib wrote:
> JDevlieghere wrote:
> > Just double checking: I assume these are always defined, even when `mach/exception.h` is not included?
> no, I'm getting the following error if I don't include `mach/exception.h `
> 
> ```
> llvm.org/lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp:525:8: error: use of undeclared identifier 'EXC_BAD_ACCESS'
>   case EXC_BAD_ACCESS:
>        ^
> ```
So doesn't that mean this won't compile on a non-apple platform? Is this whole block __APPLE__ only? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131086/new/

https://reviews.llvm.org/D131086